GH-49890: [Dev] Group files under component comment headers in `.github/CODEOWNERS` by kevingurney · Pull Request #49891 · apache/arrow

kevingurney · 2026-04-28T16:17:18Z

Rationale for this change

Based on the feedback shared by @kou in #49811 (comment), we should consider grouping files under component comment headers in .github/CODEOWNERS to improve readability.

We should also add @kevingurney and @sgilmore10 as CODEOWNERS for the MATLAB-related CI file .github/workflows/matlab.yml.

Component(s)

Developer Tools

What changes are included in this PR?

Group files under component comment headers in .github/CODEOWNERS file.
Add @kevingurney and @sgilmore10 as CODEOWNERS for file .github/workflows/matlab.yml.

Are these changes tested?

N/A.

Are there any user-facing changes?

No.

Notes

Thank you @sgilmore10 for your help with this pull request!

GitHub Issue: [Dev] Group files under component comment headers in .github/CODEOWNERS #49890

…` file. 2. Add `@kevingurney` and `@sgilmore10` as `CODEOWNERS` for file `.github/workflows/matlab.yml`. Co-authored-by: Sarah Gilmore <sgilmore@mathworks.com>

kevingurney · 2026-04-28T16:20:43Z

Note: @kou - The changes in this PR were adapted from the diff you shared in #49811 (comment). Since there was no explicit license included with this diff, please let us know if you have any concerns regarding the use of this adapted code from a copyright perspective.

raulcd

This looks good to me

kevingurney · 2026-04-29T16:10:51Z

+1

kevingurney · 2026-04-29T16:12:33Z

Before I proceed with merging this, @kou do you have any flags regarding my previous comment?

Copilot

Pull request overview

Reorganizes .github/CODEOWNERS to be more readable by grouping paths under component headers, and updates ownership for the MATLAB CI workflow file.

Changes:

Group CODEOWNERS entries under component comment headers (C GLib, C++, MATLAB, Python, R, Ruby).
Add MATLAB maintainers as CODEOWNERS for .github/workflows/matlab.yml.
Move R packaging-tooling patterns into the R section.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-30T00:59:46Z

 /matlab/ @kevingurney @kou @sgilmore10
+/.github/workflows/matlab.yml @kevingurney @sgilmore10


/.github/workflows/matlab.yml is currently listed before the broader /.github/ ... rule later in the file. In CODEOWNERS, the last matching pattern wins, so the later /.github/ entry will override this and the MATLAB-specific owners won't be applied. Move the /.github/workflows/matlab.yml rule below the /.github/ rule (or otherwise narrow the /.github/ rule) so it takes precedence for that file.

Copilot · 2026-04-30T00:59:47Z

-## Components
+# Components
+
+## C Glib


Component header uses C Glib, but the project consistently refers to this component as C GLib (e.g., .github/workflows/ruby.yml and r/_pkgdown.yml). Consider updating the header capitalization for consistency and searchability.

Suggested change

## C Glib

## C GLib

kou

+1

No problem! We can use the diff under Apache-2.0 by the ASF!

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>

kevingurney · 2026-04-30T13:53:26Z

+1

No problem! We can use the diff under Apache-2.0 by the ASF!

Thank you for confirming, @kou! My apologies for the oversight - I did not realize that diffs shared were automatically under Apache-2.0 according to the ASF!

kevingurney · 2026-04-30T14:34:30Z

After looking more closely at #49891 (comment) and reading https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#example-of-a-codeowners-file, it seems like the location of the pattern /.github/workflows/matlab.yml is problematic here.

My understanding is that /.github/workflows/matlab.yml would have to come after the "more general pattern" of /.github/ in order for the "correct" code owners to be notified.

This doesn't exactly feel ideal since the MATLAB CI pattern will no longer be associated with the MATLAB component header. However, there probably isn't anything we can really do here, so I am going to update this PR to move the MATLAB CI pattern accordingly.

Any flags with this change @kou?

`/.github/`.

kou · 2026-04-30T20:59:55Z

My apologies for the oversight - I did not realize that diffs shared were automatically under Apache-2.0 according to the ASF!

Ah, sorry. I should have explained more about this. In general, diffs in comment aren't licensed under Apache-2.0 by the ASF. The automatic Apache-2.0 by the ASF rule is applied only for my diffs. So your license confirmation process is the right approach!

kou · 2026-04-30T21:03:20Z

My understanding is that /.github/workflows/matlab.yml would have to come after the "more general pattern" of /.github/ in order for the "correct" code owners to be notified.

This doesn't exactly feel ideal since the MATLAB CI pattern will no longer be associated with the MATLAB component header. However, there probably isn't anything we can really do here, so I am going to update this PR to move the MATLAB CI pattern accordingly.

It makes sense.

We'll change

# ...
# Components
# ...
# PR CI and repository files
# ...

to

# ...
# PR CI and repository files
# ...
# Components
# ...

, right?

1. Group files under component comment headers in `.github/CODEOWNERS…

dabd9af

…` file. 2. Add `@kevingurney` and `@sgilmore10` as `CODEOWNERS` for file `.github/workflows/matlab.yml`. Co-authored-by: Sarah Gilmore <sgilmore@mathworks.com>

kevingurney requested a review from sgilmore10 April 28, 2026 16:17

kevingurney requested review from assignUser, jonkeane, kou and raulcd as code owners April 28, 2026 16:17

github-actions Bot added the awaiting committer review Awaiting committer review label Apr 28, 2026

raulcd approved these changes Apr 29, 2026

View reviewed changes

github-actions Bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Apr 29, 2026

kou requested a review from Copilot April 30, 2026 00:57

Copilot started reviewing on behalf of kou April 30, 2026 00:58 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

kou approved these changes Apr 30, 2026

View reviewed changes

kou reviewed Apr 30, 2026

View reviewed changes

Comment thread .github/CODEOWNERS Outdated

github-actions Bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Apr 30, 2026

kou reviewed Apr 30, 2026

View reviewed changes

Comment thread .github/CODEOWNERS Outdated

kevingurney and others added 2 commits April 30, 2026 09:44

Update .github/CODEOWNERS

7c2453d

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>

Update .github/CODEOWNERS

f649059

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>

github-actions Bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Apr 30, 2026

Reorder MATLAB CI workflow entry to be after the "more general" pattern

5305d22

`/.github/`.

github-actions Bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 30, 2026

		/matlab/ @kevingurney @kou @sgilmore10
		/.github/workflows/matlab.yml @kevingurney @sgilmore10

Conversation

kevingurney commented Apr 28, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

Component(s)

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Notes

Uh oh!

kevingurney commented Apr 28, 2026

Uh oh!

raulcd left a comment

Choose a reason for hiding this comment

Uh oh!

kevingurney commented Apr 29, 2026

Uh oh!

kevingurney commented Apr 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kevingurney commented Apr 30, 2026

Uh oh!

kevingurney commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kou commented Apr 30, 2026

Uh oh!

kou commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kevingurney commented Apr 28, 2026 •

edited by github-actions Bot

Loading

kevingurney commented Apr 30, 2026 •

edited

Loading